fix(model_specific): make {Fs,Gs,KernelGs}Base::write() unsafe

rust-osdev · Dec 24, 2024 · d2ef402 · d2ef402
1 parent f5a91f1
commit d2ef402
Showing 1 changed file with 18 additions and 3 deletions.
diff --git a/src/registers/model_specific.rs b/src/registers/model_specific.rs
@@ -307,8 +307,13 @@ mod x86_64 {
         ///
         /// If [`CR4.FSGSBASE`][Cr4Flags::FSGSBASE] is set, the more efficient
         /// [`FS::write_base`] can be used instead.
+        ///
+        /// ## Safety
+        ///
+        /// The caller must ensure that this write operation has no unsafe side
+        /// effects, as the segment base address might be in use.
         #[inline]
-        pub fn write(address: VirtAddr) {
+        pub unsafe fn write(address: VirtAddr) {
             let mut msr = Self::MSR;
             unsafe { msr.write(address.as_u64()) };
         }
@@ -328,8 +333,13 @@ mod x86_64 {
         ///
         /// If [`CR4.FSGSBASE`][Cr4Flags::FSGSBASE] is set, the more efficient
         /// [`GS::write_base`] can be used instead.
+        ///
+        /// ## Safety
+        ///
+        /// The caller must ensure that this write operation has no unsafe side
+        /// effects, as the segment base address might be in use.
         #[inline]
-        pub fn write(address: VirtAddr) {
+        pub unsafe fn write(address: VirtAddr) {
             let mut msr = Self::MSR;
             unsafe { msr.write(address.as_u64()) };
         }
@@ -343,8 +353,13 @@ mod x86_64 {
         }
 
         /// Write a given virtual address to the KernelGsBase register.
+        ///
+        /// ## Safety
+        ///
+        /// The caller must ensure that this write operation has no unsafe side
+        /// effects, as the segment base address might be in use.
         #[inline]
-        pub fn write(address: VirtAddr) {
+        pub unsafe fn write(address: VirtAddr) {
             let mut msr = Self::MSR;
             unsafe { msr.write(address.as_u64()) };
         }