Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate CI jobs into a single workflow #51

Closed
wants to merge 1 commit into from

Conversation

dan-manges
Copy link
Member

No description provided.

@kylekthompson
Copy link
Member

We made this change a while back to make the scripts easier to write. Do we need to change those?

@kylekthompson
Copy link
Member

Specifically, they grep for version: oldversion so if more than one binary ends up having the same version, we'll change the wrong lines

@kylekthompson
Copy link
Member

e.g.:

sed -i '' -e "s/version: \"${oldVersion}\"/version: \"${newVersion}\"/" "./.github/workflows/captain-ci.yml"

@kylekthompson
Copy link
Member

kylekthompson commented Dec 5, 2023

Maybe we could change the matrix includes to be something like {name: "abq@1", version: "1.6.3"} instead of the YAML shorthand hash syntax and then include the binary name in the sed? (not 100% sure if that works)

@dan-manges dan-manges closed this Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants