Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate chain table by mainnets and testnets #13

Closed
PaulRBerg opened this issue Nov 20, 2024 · 3 comments · Fixed by #12
Closed

Separate chain table by mainnets and testnets #13

PaulRBerg opened this issue Nov 20, 2024 · 3 comments · Fixed by #12
Assignees
Labels
effort: low Easy or tiny task that takes less than a day. priority: 2 We will do our best to deal with this. type: docs Changes to documentation.

Comments

@PaulRBerg
Copy link
Member

Here:

https://github.com/sablier-labs/v2-deployments/tree/main/core/v1.2.0#salts

Just like we did in the docs.

@PaulRBerg PaulRBerg added effort: low Easy or tiny task that takes less than a day. priority: 2 We will do our best to deal with this. type: docs Changes to documentation. labels Nov 20, 2024
@andreivladbrg
Copy link
Member

andreivladbrg commented Nov 30, 2024

currently in this PR #12 the structure is:

lockup/
├── v1.0.0
│   ├── core
│   │   ├── artifacts // both mainnets and testnets
│   │   └── broadcasts // both mainnets and testnets
│   └── periphery
│       ├── artifacts // both mainnets and testnets
│       └── broadcasts // both mainnets and testnets
├── v1.0.1

given that the structure in docs is not similar to this repo, i am not sure what your suggestion is (1, or 2?)

1:

lockup/
├── v1.0.0
│   ├── core
│   │   ├── mainnets 
│   │   │   ├── artifacts
│   │   │   └── broadcasts
│   │   └── testnets
│   │       ├── artifacts
│   │       └── broadcasts
│   └── periphery
│       ├── mainnets   
│       │   ├── artifacts
│       │   └── broadcasts
│       └── testnets
│           ├── artifacts
│           └── broadcasts
├── v1.0.1

2.

lockup/
├── v1.0.0
│   ├── mainnets
│   │   ├── core // both artifacts and broadcasts
│   │   └── periphery // both mainnets and testnets
│   └── testnets
│       ├── core // both artifacts and broadcasts
│       └── periphery // both mainnets and testnets
├── v1.0.1

@PaulRBerg
Copy link
Member Author

@andreivladbrg I am only referring to the Markdown. Introduce "Mainnets" and "Testnets" headers in the Markdwon.

@andreivladbrg
Copy link
Member

oh, i see, ok ok

@andreivladbrg andreivladbrg linked a pull request Dec 3, 2024 that will close this issue
@smol-ninja smol-ninja removed their assignment Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: low Easy or tiny task that takes less than a day. priority: 2 We will do our best to deal with this. type: docs Changes to documentation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants