Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: restructure with lockup dir #12

Merged
merged 4 commits into from
Dec 12, 2024
Merged

Conversation

andreivladbrg
Copy link
Member

@andreivladbrg andreivladbrg commented Oct 8, 2024

Closes #10, #11, #13

Important

The merge of this PR should be synchronized with renaming this repo to deployments (removing "V2") and updating the documentation in places such as this

Copy link
Member

@smol-ninja smol-ninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renaming this repo to deployment can be synchronised with renaming v2-core to lockup. So, feel free to merge this and open another issue about renaming repo.

@andreivladbrg
Copy link
Member Author

So, feel free to merge this and open another issue about renaming repo.

we need to also update the hyperlinks in docs

@smol-ninja
Copy link
Member

smol-ninja commented Oct 9, 2024

Right. So should we mark it as draft then to prevent accidental merging of this PR

@andreivladbrg
Copy link
Member Author

Right. So should we mark it as draft then to prevent accidental merging of this PR

we could, but some clarifications, doesn't "draft" mean that the work for the individual PR is not finished?
the case here is that for deployments PR is finished, but we need to updated other repos

@andreivladbrg andreivladbrg marked this pull request as draft October 9, 2024 14:24
@smol-ninja
Copy link
Member

As per https://github.blog/news-insights/product-news/introducing-draft-pull-requests/, Draft PR can be used to send various signals one of which is to block merging the pull request.

refactor: remove "V2"

refactor: divide by mainnets and testnets
@andreivladbrg andreivladbrg force-pushed the refactor/restructure-repo branch from ff95fff to ad1d2c0 Compare December 3, 2024 13:17
andreivladbrg and others added 2 commits December 7, 2024 15:39
Copy link
Member

@smol-ninja smol-ninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is another review after merging #14.

  1. ZKsync broadcasts and ZKsync artifacts are missing. ZKsync artifacts should be different because of hardhat requirement (similar to lockup directory).
  2. We should update the Scripts section in the README file as the bash scripts are no longer used to make deployments.
  3. Link to Flow npm package was missing from README which I have added in 61e0b2f.

flow/v1.0.0/README.md Show resolved Hide resolved
@andreivladbrg
Copy link
Member Author

ZKsync broadcasts

unfortunetely i didn't have them this time, i don't know why

ZKsync artifacts are missing

will add them

Co-authored-by: smol-ninja <shubhamy2015@gmail.com>
Copy link
Member

@smol-ninja smol-ninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@andreivladbrg andreivladbrg marked this pull request as ready for review December 9, 2024 15:54
@smol-ninja
Copy link
Member

Should we merge it @andreivladbrg given we are going live in a few hours? We will then have to update the links in docs as well.

@andreivladbrg andreivladbrg merged commit f696c98 into main Dec 12, 2024
@andreivladbrg andreivladbrg deleted the refactor/restructure-repo branch December 12, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate chain table by mainnets and testnets Think of a way to merge the core and periphery dirs
2 participants