-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add table creator script contract #287
Conversation
build: add more chains in foundry toml build: add etherscan config
a1e4d37
to
e400624
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question:
-
What do we do when chain details are not found in these tables? Do we re-deploy the contracts by adding these chain details such as explorer and chain name or let it go like that? IMO we should revert the deployment.
-
Have you tested these scripts? I think admin addresses are not being populated anywhere. Thus, not sure if it would work as expected.
i am not sure i understand completely what you mean? if the chain is not found, it will use the DEFAUL DEPLOYER as the
yes, i have, running the CLI ## Sepolia
| Contract | Address | Deployment |
| :---------------- | :---------------------------------------------------------------------------------------------------------------------------- | :------------------------------------------------------------------ |
| SablierFlow | [0x83dd52fca44e069020b58155b761a590f12b59d3](https://sepolia.etherscan.io/address/0x83dd52fca44e069020b58155b761a590f12b59d3) | [v1.0.0](https://github.com/sablier-labs/v2-deployments/tree/main/) |
| FlowNFTDescriptor | [0x8224eb5d7d76b2d7df43b868d875e79b11500ea8](https://sepolia.etherscan.io/address/0x8224eb5d7d76b2d7df43b868d875e79b11500ea8) | [v1.0.0](https://github.com/sablier-labs/v2-deployments/tree/main/) |
and if you simply run it multiple times, the previous deployment won't be delated i have pushed a new commit to address your feedback, lmk if it looks good |
There should be I suppose an empty folder won't be allowed by the git. In that case, we should document is in the contributing guideline or readme. Any other ideas? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last suggestions. Then all good.
Regarding this, how about putting these markdown files in the |
my bad, should have also mentioned in this PR as well, please see the OP in the lockup repo: sablier-labs/v2-core#1049 (comment) also the natspec in the contract should say this
hmm, what if we use |
Works both ways to me (you can decide). But even if its meant to be executed by us, given that its a public repo, any information required to run any command (such as forge script) should be a part of the contributing guidelines. Else a user jump into our discord and ask that why this particular command not working and we end up answering that he needs to create
Secondly, even if we expect ourselves to be aware of these things, we should also document it for future reference or external developer. |
3c37a8e
to
d39ac75
Compare
fair enough, let's move them into scripts dir |
i have addressed eveything now, thanks for the feedback does it look good to be merged? @smol-ninja |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed deployments
from .gitignore
: 27a845c
Similar to: sablier-labs/v2-core#1049
I couldn't find a better name for the contract, so I named it
TableCreator
(if you better suggestions lmk). I also didn’t think it was appropriate to include all the logic in theBase_Script
contract.Other changes
build: add more chains in foundry toml
build: add etherscan config