Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add Shared_Integration_Concrete_Test #334

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

smol-ninja
Copy link
Member

@smol-ninja smol-ninja commented Nov 11, 2024

Changelog

  1. Similar to Lockup, inherits Modifiers from Utils to make users accessible. This removes unnecessary overrides such as whenCallerAdmin and allows reusing modifiers such as givenBalanceNotZero across fuzz and concrete tests with different logic.

  2. Organise the test contracts as the following:

flowchart TD;
  Base_Test --> Integration_Test
  Integration_Test --> Shared_Integration_Concrete_Test
  Shared_Integration_Concrete_Test --> ABC_Integration_Concrete_Test
  Integration_Test --> Shared_Integration_Fuzz_Test
  Shared_Integration_Fuzz_Test --> ABC_Integration_Fuzz_Test
  Base_Test --> Fork_Test
  Fork_Test --> ABC_Fork_Test
  Base_Test --> Flow_Invariant_Test
Loading

@smol-ninja smol-ninja force-pushed the test/Shared_Integration_Concrete_Test branch from b37231b to 2598f24 Compare November 13, 2024 14:54
@smol-ninja
Copy link
Member Author

@andreivladbrg bumping this up.

Copy link
Member

@andreivladbrg andreivladbrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with the proposed changes
LGTM 👍

@smol-ninja smol-ninja merged commit de3c0a1 into main Dec 2, 2024
7 checks passed
@smol-ninja smol-ninja deleted the test/Shared_Integration_Concrete_Test branch December 2, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants