Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more endpoints in foundry.toml #1006

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Conversation

andreivladbrg
Copy link
Member

@andreivladbrg andreivladbrg commented Jul 31, 2024

Closes #1003

I have not modified deploy-multi-chain script because I am working on a new rust version of it.

@andreivladbrg andreivladbrg requested a review from smol-ninja July 31, 2024 13:06
@andreivladbrg andreivladbrg linked an issue Jul 31, 2024 that may be closed by this pull request
@andreivladbrg andreivladbrg force-pushed the build/more-endpoints branch from 269a6ca to 963edfb Compare July 31, 2024 20:27
@smol-ninja
Copy link
Member

Since the endpoints are required to deploy on new EVMs, shouldn't this PR be created against main branch?

@andreivladbrg
Copy link
Member Author

Good point, I will change the branch to main and we will rebase on staging, after merge the ongoing PRs. 👍

@andreivladbrg andreivladbrg changed the base branch from staging to main August 1, 2024 12:58
@andreivladbrg
Copy link
Member Author

Could you approve again, please? @smol-ninja

Copy link
Member

@smol-ninja smol-ninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Thanks.

@andreivladbrg andreivladbrg merged commit 75bf774 into main Aug 2, 2024
@andreivladbrg andreivladbrg deleted the build/more-endpoints branch August 2, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more endpoints in foundry.toml
2 participants