fix: address audit findings 4, 8, 10 #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recipient per se is not included in the NFT metadata, but it would be helpful to update the metadata when the NFT changes hands so that the new recipient can see the most up-to-date information on marketplaces like OpenSea. |
PaulRBerg
requested changes
Jan 6, 2025
tests/integration/concrete/lockup-base/renounce-multiple/renounceMultiple.t.sol
Outdated
Show resolved
Hide resolved
tests/integration/concrete/lockup-linear/create-with-durations-ll/createWithDurationsLL.tree
Show resolved
Hide resolved
tests/integration/concrete/lockup-linear/create-with-durations-ll/createWithDurationsLL.tree
Show resolved
Hide resolved
|
Incorporated all your suggestions @PaulRBerg. |
docs: add MetadataUpdate event in create functions natspecs
Co-authored-by: Paul Razvan Berg <prberg@proton.me>
andreivladbrg
force-pushed
the
shub/audit-fixes
branch
from
04f92c2 to
8d7bc50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following audit findings:
Note
Regarding 10th finding about
MetadataUpdateevent, I have removed it fromrenouncebut kept it in_updatesince transfering stream changes recipient and recipient is a part of stream's metadata.