Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connect consumer to call get contract metadata task #50

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Connect consumer to call get contract metadata task #50

merged 1 commit into from
Jan 8, 2025

Conversation

falvaradorodriguez
Copy link
Contributor

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12653818852

Details

  • 168 of 173 (97.11%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.1%) to 93.218%
Changes Missing Coverage Covered Lines Changed/Added Lines %
app/services/contract_metadata_service.py 105 106 99.06%
app/datasources/db/models.py 29 31 93.55%
app/workers/tasks.py 14 16 87.5%
Totals Coverage Status
Change from base Build 12595111545: 1.1%
Covered Lines: 811
Relevant Lines: 870
💛 - Coveralls

@falvaradorodriguez falvaradorodriguez changed the title Connect consumer to get metadata task Connect consumer to call get contract metadata task Jan 7, 2025
@falvaradorodriguez falvaradorodriguez marked this pull request as ready for review January 7, 2025 15:07
@falvaradorodriguez falvaradorodriguez requested a review from a team as a code owner January 7, 2025 15:07
@falvaradorodriguez falvaradorodriguez force-pushed the connect-consumer-to-get-metadata-task branch from 2043497 to d9f284c Compare January 8, 2025 14:26
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2025
@falvaradorodriguez falvaradorodriguez merged commit f909eb9 into main Jan 8, 2025
9 checks passed
@falvaradorodriguez falvaradorodriguez deleted the connect-consumer-to-get-metadata-task branch January 8, 2025 14:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@moisses89 moisses89 moisses89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Connect consumer to get_contract_metadata_task
3 participants
@falvaradorodriguez @coveralls @moisses89