Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add youtubedl_material role #313

Closed

Conversation

hereisderek
Copy link
Contributor

Description

YoutubeDL-Material is a Material Design frontend for youtube-dl. It's coded using Angular 15 for the frontend, and Node.js on the backend.

Project page: link

TODO:

  • doc page

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration. You can use the checkboxes below or delete them as you wish.

  • tested with sb install youtubedl_material
  • access the subdomain https://ytdl.domain.com and tested it's working

Copy link
Member

@saltydk saltydk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the requested changes.

roles/youtubedl_material/defaults/main.yml Show resolved Hide resolved
roles/youtubedl_material/defaults/main.yml Show resolved Hide resolved

youtubedl_material_paths_folder: "{{ youtubedl_material_name }}"
youtubedl_material_paths_location: "{{ server_appdata_path }}/{{ youtubedl_material_paths_folder }}"
youtubedl_material_download_folder: "/mnt/unionfs/Media/{{ youtubedl_material_name }}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Downloads generally do not go into Media folders

youtubedl_material_web_subdomain: "{{ youtubedl_material_name }}"
youtubedl_material_web_domain: "{{ user.domain }}"
youtubedl_material_web_port: "17442"
youtubedl_material_web_url: "{{ 'https://' + youtubedl_material_web_subdomain + '.' + youtubedl_material_web_domain
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at other roles for a reference on how to format this

################################

youtubedl_material_traefik_sso_middleware: "{{ traefik_default_sso_middleware }}"
youtubedl_material_traefik_middleware: "{{ traefik_default_middleware + ',' + youtubedl_material_traefik_sso_middleware
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at other roles for a reference on how to format this

# Labels
youtubedl_material_docker_labels_default: {}
youtubedl_material_docker_labels_custom: {}
youtubedl_material_docker_labels: "{{ docker_labels_common
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at other roles for a reference on how to format this

youtubedl_material_docker_networks_alias: "{{ youtubedl_material_name }}"
youtubedl_material_docker_networks_default: []
youtubedl_material_docker_networks_custom: []
youtubedl_material_docker_networks: "{{ docker_networks_common
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at other roles for a reference on how to format this

# Capabilities
youtubedl_material_docker_capabilities_default: []
youtubedl_material_docker_capabilities_custom: []
youtubedl_material_docker_capabilities: "{{ youtubedl_material_docker_capabilities_default
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at other roles for a reference on how to format this

# Security Opts
youtubedl_material_docker_security_opts_default: []
youtubedl_material_docker_security_opts_custom: []
youtubedl_material_docker_security_opts: "{{ youtubedl_material_docker_security_opts_default
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at other roles for a reference on how to format this

@@ -182,5 +182,6 @@
- { role: xteve, tags: ['xteve'] }
- { role: yacht, tags: ['yacht'] }
- { role: your_spotify, tags: ['your-spotify'] }
- { role: youtubedl_material, tags: ['youtubedl_material'] }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We no longer accept underscores in tags

@saltydk saltydk requested a review from owine December 22, 2023 01:49
@saltydk saltydk force-pushed the master branch 2 times, most recently from ba4842d to 6af13e1 Compare December 25, 2023 16:03
@saltydk
Copy link
Member

saltydk commented Jan 8, 2024

Close this if you don't want to do the changes for him @owine since he hasn't responded for 2 weeks I assume this will remain stagnant.

@owine owine closed this Jan 13, 2024
@owine
Copy link
Collaborator

owine commented Jan 13, 2024

Happy to reopen and revisit if the requested changes are made

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants