Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection tools refactor #112

Merged
merged 36 commits into from
Oct 1, 2024
Merged

Selection tools refactor #112

merged 36 commits into from
Oct 1, 2024

Conversation

VorTechnix
Copy link
Collaborator

Refactor seems stable.

Copy link
Owner

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this is pretty awesome! Just got some small things to tidy up and then I think this should be ready to merge!

Tried to leave suggestions to make the process easier :-)

Chat-Command-Reference.md Outdated Show resolved Hide resolved
Chat-Command-Reference.md Outdated Show resolved Hide resolved
Chat-Command-Reference.md Outdated Show resolved Hide resolved
Chat-Command-Reference.md Outdated Show resolved Hide resolved
Chat-Command-Reference.md Outdated Show resolved Hide resolved
worldeditadditions_commands/commands/selectors/sshift.lua Outdated Show resolved Hide resolved
worldeditadditions_commands/commands/selectors/sshrink.lua Outdated Show resolved Hide resolved
worldeditadditions_commands/commands/uasparse.lua Outdated Show resolved Hide resolved
worldeditadditions_commands/commands/uasparse.lua Outdated Show resolved Hide resolved
worldeditadditions_core/utils/strings/split.lua Outdated Show resolved Hide resolved
VorTechnix and others added 3 commits October 1, 2024 06:48
Co-authored-by: Starbeamrainbowlabs <sbrl@starbeamrainbowlabs.com>
Co-authored-by: Starbeamrainbowlabs <sbrl@starbeamrainbowlabs.com>
Co-authored-by: Starbeamrainbowlabs <sbrl@starbeamrainbowlabs.com>
VorTechnix and others added 6 commits October 1, 2024 06:51
Co-authored-by: Starbeamrainbowlabs <sbrl@starbeamrainbowlabs.com>
Co-authored-by: Starbeamrainbowlabs <sbrl@starbeamrainbowlabs.com>
Co-authored-by: Starbeamrainbowlabs <sbrl@starbeamrainbowlabs.com>
@sbrl
Copy link
Owner

sbrl commented Oct 1, 2024

Looks great and ready to merge!

Could you resolve the conflicts at all please, @VorTechnix?

@VorTechnix VorTechnix closed this Oct 1, 2024
@VorTechnix VorTechnix reopened this Oct 1, 2024
@VorTechnix VorTechnix merged commit f24ceff into dev Oct 1, 2024
2 of 3 checks passed
@VorTechnix VorTechnix deleted the selection-tools-refactor branch October 1, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants