Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ASSERT_NEQ_FMT and ASSERT_NEQ_FMTm #110

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

msterin
Copy link

@msterin msterin commented May 11, 2021

There are nice new macros ASSERT_NEQ and ASSERT_NEQm in 1.15. This PR adds missing FMT macros for NEQ comparison.

FWIW we are using this in our test suite (including support similar to NEQ) and it's a very nice tool - thanks to the author and everyone contributing.

I did not find any special requirements for PR (other that to submit to develop branch), so submitting as is.

Thanks !

@msterin msterin changed the title Added ASSERT_NEQ_FMT and ASSERT_NEQ_FMTm WIP: Added ASSERT_NEQ_FMT and ASSERT_NEQ_FMTm May 11, 2021
@msterin msterin changed the title WIP: Added ASSERT_NEQ_FMT and ASSERT_NEQ_FMTm Added ASSERT_NEQ_FMT and ASSERT_NEQ_FMTm May 11, 2021
@silentbicycle
Copy link
Owner

Glad it has been useful.

The code change looks good. I will probably rework it a bit before integrating it in the next release (probably combining common elements with GREATEST_ASSERT_EQ_FMTm), but that's because of my self-imposed line of code limit, which isn't your problem. :)

@msterin
Copy link
Author

msterin commented May 18, 2021

Glad it has been useful.

The code change looks good. I will probably rework it a bit before integrating it in the next release (probably combining common elements with GREATEST_ASSERT_EQ_FMTm), but that's because of my self-imposed line of code limit, which isn't your problem. :)

awesome, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants