Add support for exact paths when specified as locations #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howardburgess
requested changes
Mar 18, 2019
howardburgess
previously approved these changes
Mar 19, 2019
alangibson01
force-pushed
the
add-support-for-exact-paths
branch
from
f01a7e4 to
b324c36
Compare
|
@howardburgess I've done one more commit to add an entry to the CHANGELOG. Could you take another look, please? I rebased from master in order to pick up an entry in the CHANGELOG that was merged to master earlier this week, after this branch was taken. |
howardburgess
previously approved these changes
Mar 21, 2019
|
Sorry, @howardburgess, one more time please - I messed up the version number in the changelog. |
howardburgess
approved these changes
Mar 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goes some way to resolving #192.
Right now, if an ingress specifies a path of e.g.
/my/test/path, this will be rendered in the location block aslocation /my/test/path/. If a browser then hits/my/test/pathit will be redirected to/my/test/path/with a 301 permanent redirect.If
/my/test/pathis not a directory, but is instead an absolute path to a resource, then redirecting to/my/test/path/simply doesn't make sense. This PR introduces the concept of "exact paths" by allowing ingresses to specify if all of their paths are absolute paths to resources. If so, we render the path aslocation = <raw path value>.