feat: ignore local path as version

smarlhens · Oct 17, 2023 · ef27aba · ef27aba
1 parent cbe75f0
commit ef27aba
Show file tree

Hide file tree

Showing 4 changed files with 43 additions and 1 deletion.
diff --git a/examples/workspace/foo/package.json b/examples/workspace/foo/package.json
@@ -4,6 +4,7 @@
   "dependencies": {
     "fake-package-1": "^1.0.0",
     "fake-package-2": "^2.0.0",
-    "fake-package-3": "^3.0.0"
+    "fake-package-3": "^3.0.0",
+    "fake-package-4": "file:../vendor/foo-1.2.3.tgz"
   }
 }
diff --git a/examples/workspace/package-lock.json b/examples/workspace/package-lock.json
diff --git a/lib/npd.ts b/lib/npd.ts
@@ -492,6 +492,12 @@ export const pinDependencies = (ctx: PinDependenciesInput): PinDependenciesOutpu
 
     for (const dependencyName of Object.keys(packageJson[dependencyType])) {
       const userDefinedVersion = packageJson[dependencyType][dependencyName];
+
+      if (userDefinedVersion.startsWith('file:')) {
+        debug(`Dependency ${chalk.white(dependencyName)} is using a local path as version.`);
+        continue;
+      }
+
       let dependencyKey: string = resolver.resolveDependencyKey({
         name: dependencyName,
         version: userDefinedVersion,

diff --git a/tests/pin-from-obj.spec.ts b/tests/pin-from-obj.spec.ts
@@ -149,4 +149,31 @@ describe('pin from obj', () => {
       versionsToPin: [],
     });
   });
+
+  it('should continue if dependency is using a local path as version', async () => {
+    const params: PinDependenciesInput = {
+      packageJson: {
+        dependencies: {
+          'fake-package-1': 'file:../vendor/foo.tgz',
+        },
+      },
+      packageLockFile: {
+        content: {
+          lockfileVersion: 3,
+          packages: {
+            'node_modules/fake-package-1': { version: '1.2.3', resolved: 'file:../vendor/foo.tgz' },
+          },
+        },
+      },
+    };
+    const payload = pinDependencies(params);
+    expect(payload).toEqual({
+      packageJson: {
+        dependencies: {
+          'fake-package-1': 'file:../vendor/foo.tgz',
+        },
+      },
+      versionsToPin: [],
+    });
+  });
 });