Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

music player added #112

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Conversation

ritikm31
Copy link
Contributor

@ritikm31 ritikm31 commented Oct 5, 2024

here I added music player app.

Related Issue #110

Description

I added this music player app in these repo.

Type of PR

[ music player added]Feature enhancement

Checklist:

I have performed a self-review of my code
I have read and followed the Contribution Guidelines.
I have tested the changes thoroughly before submitting this pull request.
I have provided relevant issue numbers, screenshots, and videos after making the changes.
I have commented my code, particularly in hard-to-understand areas.

here I added music player app.
Copy link

github-actions bot commented Oct 5, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@ritikm31
Copy link
Contributor Author

ritikm31 commented Oct 5, 2024

it's my honour to contribute in your project and it's my first time when I contribute to an open source. hope it works

@smilewithkhushi smilewithkhushi added enhancement New feature or request level2 Level 2 Issue for GSSoC'24 gssoc-ext labels Oct 7, 2024
Copy link
Owner

@smilewithkhushi smilewithkhushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! please try to include comments and some documentation next time :)

@smilewithkhushi smilewithkhushi merged commit 99d6341 into smilewithkhushi:master Oct 7, 2024
@ritikm31
Copy link
Contributor Author

ritikm31 commented Oct 8, 2024

ok i remember it next time, thanks for the appreciation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc-ext level2 Level 2 Issue for GSSoC'24
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants