fix: Fix code navigation for enum values #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varungandhi-src
commented
Jul 16, 2024
Comment on lines
-13
to
+12
| # ^ definition local 2~#119448696 | ||
| # ^ definition [..] X#A# | ||
| # ^ reference [..] X#A# | ||
| # ^ reference [..] X#A. | ||
| # ^ definition [..] X#A. |
There was a problem hiding this comment.
The main change is that this correctly shows up as a definition rather than as a reference, and that spurious entities are no longer present here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
With this patch, we reduce divergence from Sorbet by using a zero-length location
for the synthetic classes generated when rewriting enums. We also add a special-case
for emitting definitions for enum values, since I wasn't able to figure out a better
way to do the same thing.
Fixes #214
Test plan
Covered by snapshot tests.