fix: Emit reference relationships for constant aliases #225
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GRAPH-979.
When you have "constant aliases" of the form:
It would be nice to merge code navigation results for X and Y so
that when you do Find references across either of them, you see
all references for either X or Y.
Part of the logic for this lives in the Sourcegraph backend,
and that needs some fixes in terms of building an extra
inverted index etc. So with this patch, current versions of
Sourcegraph (as of Oct 28 2024) will show merged
references when doing Find references on Y (but not X).
However, this fixes the indexer side of the logic by emitting
Relationships with
is_reference
set, so that the backendcan utilize it.
When testing against the shopify-api-ruby repo, I get the following
additional relationships.
Test plan
See included automated tests.