Fix steep:ignore does not work with CR/LF #1406
Open
+18
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parser gem removes CR characters before parsing. Therefore `Parser:: Source::Buffer` does not contain any CR characters. As a result, `Parser::Source::Comment` points the location without CR characters. On the other hand, `RBS::Buffer` contains CR characters. This difference causes `steep:ignore` comment disabled. This converts the location of comments using line and column Close soutaro#1376
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parser gem removes CR characters before parsing. Therefore
Parser:: Source::Bufferdoes not contain any CR characters. As a result,Parser::Source::Commentpoints the location without CR characters.On the other hand,
RBS::Buffercontains CR characters. This difference causessteep:ignorecomment disabled.This converts the location of comments using line and column
Close #1376