fix(roles/file): Handle empty file-based roles. (#227)

spinnaker · May 14, 2018 · c480983 · c480983
1 parent 6b05e17
commit c480983
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/...-file/src/main/java/com/netflix/spinnaker/fiat/roles/file/FileBasedUserRolesProvider.java b/...-file/src/main/java/com/netflix/spinnaker/fiat/roles/file/FileBasedUserRolesProvider.java
@@ -102,9 +102,12 @@ static class UserRoles {
     List<Role> roles;
 
     public List<Role> getRoles() {
+      if (roles == null) {
+        return Collections.emptyList();
+      }
       return roles.stream()
-                  .map(r -> new Role(r.getName()).setSource(Role.Source.FILE))
-                  .collect(Collectors.toList());
+          .map(r -> new Role(r.getName()).setSource(Role.Source.FILE))
+          .collect(Collectors.toList());
     }
   }
 }
diff --git a/fiat-file/src/test/resources/fiat-test-permissions.yml b/fiat-file/src/test/resources/fiat-test-permissions.yml
@@ -7,3 +7,7 @@ users:
    roles:
    - crimeFighter
    - jokerJailer
+ - username: robin
+   roles: []
+ - username: nanana
+