Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): Exception in fresh development environment (LocalGit) #1069

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(config): Exception in fresh development environment (LocalGit) #1069

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions fiat-web/config/fiat.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,15 @@ server:
redis:
connection: ${services.redis.baseUrl:redis://localhost:6379}

services:
clouddriver:
baseUrl: http://localhost:7003
front50:
baseUrl: http://localhost:8080
igor:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest defaulting igor to enabled: false as it isn't a core service.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's NORMALLY a default spinnaker.yml file that should set all of these appropriately. I know that's deployed via halyard/operator. I though local dev had it someplace too, or at least, had localhost as the defaults on some of these.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe Kork?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought these files were included someplace else and so MAY not need to be set this way kinda thing...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the gate, only the fiat baseUrl was missing:
https://github.com/spinnaker/gate/pull/1671/files

enabled: false
baseUrl: http://localhost:8086

okHttpClient:
retries:
maxElapsedBackoffMs: 5000
Expand Down