Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to provide HTTP headers, Configure whether to open URLs when validating assets #114

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vprivat-ads
Copy link
Contributor

@vprivat-ads vprivat-ads commented Dec 2, 2024

@vprivat-ads vprivat-ads force-pushed the http_headers branch 3 times, most recently from e4bd703 to bec3513 Compare December 3, 2024 10:28
@vprivat-ads vprivat-ads changed the title Allow to provide HTTP headers Allow to provide HTTP headers, Configure whether to open URLs when validating assets Jan 3, 2025
@vprivat-ads vprivat-ads marked this pull request as ready for review January 3, 2025 15:14
@vprivat-ads
Copy link
Contributor Author

Hi @jonhealy1 (and happy new year!)

I've completed my work on this PR, it is now ready for review.

Copy link
Collaborator

@jonhealy1 jonhealy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have a test for these additions. It can similar to the test in stac-validator.


No ASSET format errors!

No ASSET request errors!
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this line, 'No ASSET request errors!', be changed or at least removed when using the --no-assets-urls option? We aren't checking ASSET requests I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants