Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues if canvas is scaled #9

Open
CodeDoctorDE opened this issue Sep 22, 2022 · 3 comments
Open

Issues if canvas is scaled #9

CodeDoctorDE opened this issue Sep 22, 2022 · 3 comments

Comments

@CodeDoctorDE
Copy link

CodeDoctorDE commented Sep 22, 2022 •
edited
Loading

If you have a scaled canvas, there are issues.
brave_Hc8vpBigBv
see https://butterfly-lhuv8bd8w-linwood.vercel.app/ (click on the pen painter, enable "zoom dependent" and zoom in a lot).
grafik

See here: https://github.com/LinwoodCloud/Butterfly/blob/c97a86e8080ea62183033abeae1b48011c0b9a3f/app/lib/renderers/elements/path.dart#L50
@CodeDoctorDE
Copy link
Author

@steveruizok maybe it has something to do with the steps: https://github.com/steveruizok/perfect-freehand-dart/blob/main/lib/src/get_stroke_outline_points.dart#L164
On a scaled canvas, the steps are bigger.

@adil192 adil192 mentioned this issue Dec 29, 2022
Closed
@CodeDoctorDE
Copy link
Author

This happens on all platform for me

@CodeDoctorDE
Copy link
Author

@steveruizok Excalidraw has also the issue if zooming in and trying to draw freehand. https://excalidraw.com/

adil192 added a commit that referenced this issue Feb 6, 2024
@adil192
fix: error when lerping NaN points
199ffce 
[ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: 'dart:ui/lerp.dart': Failed assertion: line 19 pos 10: '<optimized out>': Cannot interpolate between finite and non-finite values
#0      _AssertionError._doThrowNew (dart:core-patch/errors_patch.dart:51:61)
#1      _AssertionError._throwNew (dart:core-patch/errors_patch.dart:40:5)
#2      lerpDouble (dart:ui/lerp.dart:19:10)
#3      PointVector.lerp (package:perfect_freehand/src/types/point_vector.dart:54:7)
#4      getStrokeOutlinePoints (package:perfect_freehand/src/get_stroke_outline_points.dart:238:31)
#5      getStroke (package:perfect_freehand/src/get_stroke.dart:19:10)
#6      Stroke._getPolygon (package:saber/components/canvas/_stroke.dart:200:21)
#7      Stroke._updatePolygon (package:saber/components/canvas/_stroke.dart:48:16)
#8      Stroke.polygon (package:saber/components/canvas/_stroke.dart:38:32)
#9      Stroke.toSvgPath (package:saber/components/canvas/_stroke.dart:247:9)
#10     EditorExporter.generatePdf.<anonymous closure>.<anonymous closure> (package:saber/data/editor/editor_exporter.dart:111:52)
#11     CustomPaint.paint (package:pdf/src/widgets/basic.dart:623:25)
#12     SingleChildWidget.paintChild (package:pdf/src/widgets/widget.dart:320:14)
#13     ConstrainedBox.paint (package:pdf/src/widgets/basic.dart:449:5)
#14     StatelessWidget.paint (package:pdf/src/widgets/widget.dart:260:15)
#15     Page.paint (package:pdf/src/widgets/page.dart:246:13)
#16     Page.postProcess (package:pdf/src/widgets/page.dart:179:5)
#17     Document.save (package:pdf/src/widgets/document.dart:130:14)
#18     EditorState.exportAsPdf (package:saber/pages/editor/editor.dart:1213:72)
<asynchronous suspension>
#19     _ExportBarState._onPressed.<anonymous closure>.<anonymous closure> (package:saber/components/toolbar/export_bar.dart:38:29)
<asynchronous suspension>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@CodeDoctorDE