Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missmatch between PHPDoc and the reality on User::getRoles() #1646

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Missmatch between PHPDoc and the reality on User::getRoles() #1646

wants to merge 1 commit into from
+1 −8

Conversation

Curryed
Copy link

@Curryed Curryed commented Jan 14, 2025 •
edited
Loading

See description in #1652

@Curryed Curryed mentioned this pull request Jan 14, 2025
Open
@kbond
Copy link
Member

kbond commented Jan 14, 2025

Thanks for digging into this @Curryed.

What about removing the @return docblock and just letting the UserInterface dictate? I typically never override docblocks from interfaces/abstract classes (unless required) but maybe I'm in the minority?

@Curryed Curryed force-pushed the fix/roles-are-not-a-list branch from d621686 to 507afc1 Compare January 15, 2025 08:01
@Curryed
Copy link
Author

Curryed commented Jan 15, 2025

Sure! If that's the way you usually go for 😁

I updated the it removing the @return :)

kbond
kbond approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@kbond kbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbond kbond kbond approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Curryed @kbond