Merge pull request #2 from techno-dwarf-works/feature/refactoring

Version 0.0.3
techno-dwarf-works · Oct 7, 2024 · 5834709 · 5834709
1 parent 8d5574f
commit 5834709
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 39 deletions.
diff --git a/Editor/EditorAddons/Settings/SelectElementBehaviour.cs b/Editor/EditorAddons/Settings/SelectElementBehaviour.cs
diff --git a/Editor/EditorAddons/Settings/SelectElementBehaviour.cs.meta b/Editor/EditorAddons/Settings/SelectElementBehaviour.cs.meta
diff --git a/Editor/EditorAddons/Settings/ValidationSettings.cs b/Editor/EditorAddons/Settings/ValidationSettings.cs
@@ -10,9 +10,11 @@
 
 namespace Better.Validation.EditorAddons.Settings
 {
-    [ScriptableCreate(PrefixConstants.BetterPrefix + "/" + nameof(Editor) + "/" + nameof(Validation))]
+    [ScriptableCreate(SettingsPath)]
     public class ValidationSettings : ScriptableSettings<ValidationSettings>
     {
+        public const string SettingsPath = PrefixConstants.BetterPrefix + "/" + nameof(Editor) + "/" + nameof(Validation);
+
         [SerializeField] private bool _disableBuildValidation;
         [SerializeField] private ValidationType _buildLoggingLevel = ValidationType.Warning;
 

diff --git a/Editor/EditorAddons/Settings/ValidationSettingsProvider.cs b/Editor/EditorAddons/Settings/ValidationSettingsProvider.cs
@@ -2,33 +2,22 @@
 using Better.Internal.Core.Runtime;
 using Better.ProjectSettings.EditorAddons;
 using UnityEditor;
-using UnityEditor.UIElements;
-using UnityEngine.UIElements;
 
 namespace Better.Validation.EditorAddons.Settings
 {
-    internal class ValidationSettingsProvider : ProjectSettingsProvider<ValidationSettings>
+    internal class ValidationSettingsProvider : DefaultProjectSettingsProvider<ValidationSettings>
     {
-        private readonly Editor _editor;
         public const string Path = PrefixConstants.BetterPrefix + "/" + nameof(Validation);
 
         public ValidationSettingsProvider() : base(Path)
         {
             keywords = new HashSet<string>(new[] { "Better", "Validation", "Warnings", "Ignore" });
-            _editor = Editor.CreateEditor(_settings);
         }
 
         [MenuItem(Path + "/" + PrefixConstants.HighlightPrefix, false, 999)]
         private static void Highlight()
         {
             SettingsService.OpenProjectSettings(ProjectPath + Path);
         }
-
-        //TODO: maybe change to new InspectorElement(_editor); for DefaultProjectSettingsProvider<T>
-        protected override void CreateVisualElements(VisualElement rootElement)
-        {
-            var inspectorElement = new InspectorElement(_editor);
-            rootElement.Add(inspectorElement);
-        }
     }
 }
diff --git a/package.json b/package.json
@@ -1,14 +1,14 @@
 {
   "name": "com.tdw.better.validation",
   "displayName": "Better Validation",
-  "version": "0.0.2",
+  "version": "0.0.3",
   "unity": "2021.3",
   "description": " ",
   "dependencies": {
     "com.tdw.better.internal.core": "0.0.2",
-    "com.tdw.better.commons" : "0.0.44",
-    "com.tdw.better.attributes" : "0.0.1",
-    "com.tdw.better.projectsettings": "0.1.3"
+    "com.tdw.better.commons" : "0.0.57",
+    "com.tdw.better.attributes" : "0.0.2",
+    "com.tdw.better.projectsettings": "0.1.4"
   },
   "author": {
     "name": "Better Plugins",