Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix safe_exec #381

Closed
wants to merge 2 commits into from
Closed

Fix safe_exec #381

wants to merge 2 commits into from

Conversation

thinkst-az
Copy link
Contributor

Proposed changes

A recent change restricted the PATH directories where unqualified executables were launched from. This fixes it, and simplifies it's implementation with stdlib's shutil.which.

Types of changes

What types of changes does your code introduce to this repository?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Lint and unit tests pass locally with my changes (if applicable)
  • I have run pre-commit (pre-commit in the repo)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Linked to the relevant github issue or github discussion

@thinkst-az thinkst-az closed this Oct 18, 2024
@thinkst-az thinkst-az deleted the fix_safe_exec branch October 18, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant