-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Enclave Wallet Functionality #820
Conversation
import { EnclaveWallet } from "thirdweb/dist/types/wallets/in-app/core/wallet/enclave-wallet"; | ||
import { getUserStatus } from "thirdweb/dist/types/wallets/in-app/core/actions/get-enclave-user-status"; | ||
import type { Ecosystem } from "thirdweb/dist/types/wallets/in-app/core/wallet/types"; | ||
import { ClientScopedStorage } from "thirdweb/dist/types/wallets/in-app/core/authentication/client-scoped-storage"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was there no way to just use inAppWallet()
/ ecosytemWallet
for this?
can't really access these internal things like that. Might be worth exposing some of these if you need them, but probably with a bit higher level api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restating from internal for posterity: I have made the changes to use the preferred functions, however storage within the current design causes unintended results because it is not a browser environment, and will need to be addressed
50a87c6
to
cfccfc7
Compare
This PR is stale because it has been open for 7 days with no activity. Remove stale label or comment or this PR will be closed in 3 days. |
This PR is stale because it has been open for 7 days with no activity. Remove stale label or comment or this PR will be closed in 3 days. |
Changes
How this PR will be tested
Output
(Example: Screenshot/GIF for UI changes, cURL output for API changes)
PR-Codex overview
This PR introduces support for
EnclaveWallet
functionality across various modules, enhancing transaction handling and account management by incorporating new types and parameters related to the enclave wallet.Detailed summary
MemoryStorage
class for async storage implementation.SendTransactionData
to includeenclave
parameter.doSimulateTransaction
to acceptenclave
parameters.EnclaveWalletParams
interface and related methods inget-enclave-wallet
.getAccount
to handleenclave
parameters.