Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TOOL-2900]: Fix metadata.attributes being ignored #824

Merged

Conversation

dirtycajunrice
Copy link
Contributor

@dirtycajunrice dirtycajunrice commented Jan 2, 2025

Changes

How this PR will be tested

  • Open the dashboard and click X. Result: A modal should appear.
  • Call the /foo/bar API. Result: Returns 200 with "baz" in the response body.

Output

(Example: Screenshot/GIF for UI changes, cURL output for API changes)


PR-Codex overview

This PR updates the erc721mintTo and erc1155mintTo functions to modify how properties are assigned from metadata. It introduces a fallback to use metadata.attributes if metadata.properties is not available.

Detailed summary

  • In src/server/routes/contract/extensions/erc721/write/mint-to.ts:

    • Changed properties: metadata.properties to properties: metadata.properties || metadata.attributes.
  • In src/server/routes/contract/extensions/erc1155/write/mint-to.ts:

    • Changed properties: metadata.properties to properties: metadata.properties || metadata.attributes.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

linear bot commented Jan 2, 2025

Copy link

zeet-co bot commented Jan 2, 2025

We're building your pull request over on Zeet.
Click me for more info about your build and deployment.
Once built, this branch can be tested at: https://npclabs-engine-cz7o-01-02-tool-29-b07cad.engine-dedi-npclabs.zeet.app before merging 😉

Copy link

zeet-co bot commented Jan 2, 2025

We're building your pull request over on Zeet.
Click me for more info about your build and deployment.
Once built, this branch can be tested at: https://pixelynx-engine-dslj-01-02-tool-2-3011dc.engine-aws-usw2.zeet.app before merging 😉

Copy link

zeet-co bot commented Jan 2, 2025

We're building your pull request over on Zeet.
Click me for more info about your build and deployment.
Once built, this branch can be tested at: https://thirdweb-engine-ad8x-01-02-tool-2-aa95b9.engine-aws-usw2.zeet.app before merging 😉

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@arcoraven arcoraven merged commit 859ed74 into main Jan 4, 2025
7 of 8 checks passed
@arcoraven arcoraven deleted the 01-02-_tool-2900_fix_metadata.attributes_being_ignored branch January 4, 2025 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants