Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: minor UI updates #99

Merged
merged 6 commits into from
Aug 29, 2024
Merged

feat: minor UI updates #99

merged 6 commits into from
Aug 29, 2024

Conversation

Eggrror404
Copy link
Collaborator

probably the last update i'll do on here util next year

fixes ui / impl things, adds things that i wanted

we're no longer interested in having twoslash inference in codeblocks.
for us codeblocks should just be a general code display, not
specifically for typescript.
* removed pageInfo.ts file
* we're now specifying each page's meta tags in their +page.ts file, as
it's more organized
* we have default meta tags in place
* page titles and breadcumb is reimplemented with component props
* removed unused toaster component
added function `localeDate()` warpping the `Date.toLocaleString()`
function.

this was added because our `date` metadata might be invalid, in which
case we should display the original string instead of showing
`undefined`.

the function was removed in a previous commit, and is brought back
because of convenience. (the implementation isn't quite understandable,
and is used in more than 1 place.)
@Eggrror404
Copy link
Collaborator Author

currently left on draft because there might be something that i wanted and forgot about.

@Eggrror404 Eggrror404 marked this pull request as ready for review August 28, 2024 17:27
@Eggrror404 Eggrror404 requested a review from HeyLoon August 28, 2024 17:29
Copy link
Collaborator

@HeyLoon HeyLoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unimpeachable

@Eggrror404
Copy link
Collaborator Author

this is #99 btw

we should just open issue #100 to celebrate it

@HeyLoon
Copy link
Collaborator

HeyLoon commented Aug 28, 2024

this is #99 btw

we should just open issue #100 to celebrate it

You opened at least 98 of the 99 🥰
hardo workingu man

@Eggrror404 Eggrror404 merged commit 7a5be42 into main Aug 29, 2024
1 check passed
@Eggrror404 Eggrror404 deleted the feat/minor-ui-updates branch August 29, 2024 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants