Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Requests: Add update / remove delete #8207

Merged
merged 3 commits into from
Sep 22, 2024
Merged

Conversation

N-o-Z
Copy link
Member

@N-o-Z N-o-Z commented Sep 22, 2024

Closes #8202

Change Description

Add UpdatePullRequest, remove support for delete

Testing Details

Added unit tests

@N-o-Z N-o-Z added exclude-changelog PR description should not be included in next release changelog pull-requests labels Sep 22, 2024
@N-o-Z N-o-Z requested review from itaigilo and a team September 22, 2024 16:36
@N-o-Z N-o-Z self-assigned this Sep 22, 2024
Copy link

github-actions bot commented Sep 22, 2024

♻️ PR Preview a00c1b4 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

Copy link

E2E Test Results - DynamoDB Local - Local Block Adapter

13 passed

Copy link

E2E Test Results - Quickstart

10 passed

@N-o-Z N-o-Z force-pushed the task/pulls-update-delete-8202 branch from d8690a2 to fc5da5a Compare September 22, 2024 17:00
Copy link
Contributor

@itaigilo itaigilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Only some nit.

pkg/catalog/fake_graveler_test.go Outdated Show resolved Hide resolved
pkg/graveler/graveler.go Outdated Show resolved Hide resolved
@@ -88,6 +88,9 @@ func ValidatePullRequestID(v interface{}) error {

// TODO (niro): Any other validations?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This TODO is done and can be removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No - still relevant

@N-o-Z N-o-Z merged commit e419027 into master Sep 22, 2024
38 of 39 checks passed
@N-o-Z N-o-Z deleted the task/pulls-update-delete-8202 branch September 22, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude-changelog PR description should not be included in next release changelog pull-requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pull Requests MVP: Update/Delete Pull Request
2 participants