-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull Requests: Add update / remove delete #8207
Conversation
♻️ PR Preview a00c1b4 has been successfully destroyed since this PR has been closed. 🤖 By surge-preview |
d8690a2
to
fc5da5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Only some nit.
@@ -88,6 +88,9 @@ func ValidatePullRequestID(v interface{}) error { | |||
|
|||
// TODO (niro): Any other validations? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This TODO is done and can be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No - still relevant
Closes #8202
Change Description
Add UpdatePullRequest, remove support for delete
Testing Details
Added unit tests