Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR - Mission Data Downloader #78

Closed

Conversation

luigigisolfi
Copy link
Contributor

This PR adds the following files:

mission_data_downloader.ipynb
mission_data_downloader.py
mission_data_downloader_class.py

To the tudatpy-examples/estimation/ folder.

Users can now download:
Spice Kernels, Radio Science Files, Ancillary Data Files

For the following supported missions:
MRO (Spice Kernels, Radio Science Files, Ancillary Data Files)
MEX (Spice Kernels, Radio Science Files, Ancillary Data Files)
JUICE (Spice Kernels only. Others are not available yet, but will be in the future.)

@DominicDirkx
Copy link
Member

@luigigisolfi Thanks for opening this PR! I think this functionality is going to make a lot of difference in setting up more complicated Tudat applications :)

I have a question/request, could we split it into two, with:

  • One PR in tudatpy, containing the functionality of the automatic downloader
  • One PR here with a (small) example of the automatic downloading
    I think the functionality you've set up is too valuable to have 'restricted' to the examples.

I can already go through the code and make comments/suggestions, so the two processes can run in parallel. If needed, someone (@alfonsoSR , @alopezrivera ?) could help out in how/where to add this to tudatpy. I think having this in the tudatpy.data submodule would be the most suitable. Your new functionality is all (?) contained inside a set of classes right?

@luigigisolfi
Copy link
Contributor Author

luigigisolfi commented Nov 13, 2024

Your new functionality is all (?) contained inside a set of classes right?

Yes, that's correct. As it is now, users only need to import the required modules defined in the class file via:
from mission_data_downlaoder_class.py import *

This solution works for me! And yes, I could use some help from @alfonsoSR or @alopezrivera :)

@alfonsoSR
Copy link

What do you need help with? :)

@luigigisolfi
Copy link
Contributor Author

What do you need help with? :)

Hey Alfonso! Thanks for this reply, I had missed it. Anywyay, I managed to implement everything myself.
We can now close this PR (#78), which will be superseded by PR (#82). PR #82 is meant to be combined with the tudatpy-PR #193.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants