Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes unit tests in the new ingest pipeline #28

Merged
merged 4 commits into from
Dec 17, 2024
Merged

Fixes unit tests in the new ingest pipeline #28

merged 4 commits into from
Dec 17, 2024

Conversation

wpfl-dbt
Copy link
Collaborator

Context

Unit tests weren't passing and are unstable. This fixes.

Changes proposed in this pull request

  • Patched hierarchical clusters test better
  • Change structure for stability

Guidance to review

  • Check you're happy with some of the parameterisation that's more for unit tests than usage

Checklist:

  • My code follows the style guidelines of this project
  • New and existing unit tests pass locally with my changes

@wpfl-dbt wpfl-dbt requested a review from leo-mazzone December 17, 2024 08:36
@wpfl-dbt wpfl-dbt changed the title Fixed unit tests, passing Fixes unit tests in the new ingest pipeline Dec 17, 2024
@wpfl-dbt wpfl-dbt marked this pull request as ready for review December 17, 2024 09:50
leo-mazzone
leo-mazzone approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@leo-mazzone leo-mazzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wpfl-dbt wpfl-dbt merged commit 28665c1 into feature/new-ingest-process Dec 17, 2024
3 checks passed
@wpfl-dbt wpfl-dbt deleted the fix/hierarchical-unit-test branch December 17, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leo-mazzone leo-mazzone leo-mazzone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wpfl-dbt @leo-mazzone