Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-implement connected components with disjoint sets #31

Merged
merged 7 commits into from
Dec 18, 2024
Merged

Re-implement connected components with disjoint sets #31

merged 7 commits into from
Dec 18, 2024

Conversation

leo-mazzone
Copy link
Collaborator

@leo-mazzone leo-mazzone commented Dec 18, 2024 •
edited
Loading

Context

Changes proposed in this pull request

  • Re-implemented disjoint set in a simpler and more canonical way
  • Unit-tested disjoint set
  • Instead of using diff-based approach, reverting construction of hierarchical clusters to ultimate-parents based dictionary

Checklist:

  • My code follows the style guidelines of this project
  • New and existing unit tests pass locally with my changes

wpfl-dbt
wpfl-dbt reviewed Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@wpfl-dbt wpfl-dbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand some of the deviations from CLRS but am satisfied that the unit tests illustrate that it works.

src/matchbox/common/results.py Outdated Show resolved Hide resolved
test/common/test_results.py Show resolved Hide resolved
src/matchbox/common/results.py Outdated Show resolved Hide resolved
@wpfl-dbt
Copy link
Collaborator

Discussed: happy this implements CLRS exactly.

wpfl-dbt
wpfl-dbt approved these changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@wpfl-dbt wpfl-dbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leo-mazzone leo-mazzone merged commit 40c4341 into feature/new-ingest-process Dec 18, 2024
3 checks passed
@leo-mazzone leo-mazzone deleted the fix/disjoint-sets branch December 18, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpfl-dbt wpfl-dbt wpfl-dbt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leo-mazzone @wpfl-dbt