Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added function to compile queries from matchbox #40

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

wpfl-dbt
Copy link
Collaborator

@wpfl-dbt wpfl-dbt commented Jan 10, 2025

Context

We need to be able to compile queries to SQL so we can quickly assess them on a live database while developing Matchbox. This PR adds a function to compile query() to raw SQL.

Note it doesn't replicate the entire function, as query() needs a data warehouse, but it reproduces the most costly SQL we'll need to run on the server.

Note 90% of this work is plundered from @nimonika 's feature/generate_query_for_benchmarking branch.

Changes proposed in this pull request

  • Adds compile_query_sql() and unit test
  • Ruff version bump to pass GitHub action. I know this is poor practise but it's not a big PR, please forgive me

Guidance to review

  • Verify you're happy that this function reflects the more important functionality of query()
  • Verify you're happy with what computation I've chosen to put into this function

Checklist:

  • My code follows the style guidelines of this project
  • New and existing unit tests pass locally with my changes

@wpfl-dbt wpfl-dbt requested a review from nimonika January 10, 2025 14:24
@nimonika nimonika merged commit b73e80f into feature/new-ingest-process Jan 10, 2025
3 checks passed
@wpfl-dbt wpfl-dbt deleted the feature/compile-query branch January 10, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants