Remove WithoutParams

[SimonAlling]

It is a special case of WithParams only used for ListAllReleases.

(Removing the WithParams abstraction altogether seems to be a completely different story – much harder than implied by the types of CreateRelease et al., mux.Vars and http.HandlerFunc.)

[SimonAlling]

This comment on #1311 is somewhat relevant.

[andresmgot]

Thanks for the investigation @SimonAlling

With the current status, I am not sure of the benefits of this particular change. I'd rather have WithoutParams to clarify that the method doesn't require external parameters rather than calling WithParams with an empty object for the params. I think the former is more readable. What do you think?

[SimonAlling]

I think my inner typechecker is trying to convince me that the empty map is also a map, but I definitely see your point. I tried redefining WithoutParams as a wrapper around WithParams to dry the code up a bit, but Go's type system is beyond me sometimes.

[SimonAlling]

Since the PR doesn't even pass the CI and it doesn't add a lot of value anyway, I'm closing it.

[andresmgot]

FWIW the error in the CI is unrelated to your changes, it's just a flaky test. Thanks anyway!