unit_file: allow arbitrary symlink targets #511
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Absolutepath is exactly what it says: it forces the link target to be
an absolute path, that is to start with a slash (`/`). But I
actually *want* to have relative symlinks.
This is particularly useful when doing a @.service template where the
instance refers to the template, often in the same directory.
This, for example, should be allowed:
systemd::unit_file { "pgbackrest-backup-${kind}@${shortname}.service":
enable => false,
active => false,
target => "pgbackrest-backup-${kind}@.service",
}
Yet it currently crashes with:
Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Resource Statement, Systemd::Unit_file[pgbackrest-backup-full@rude.service]: parameter 'target' expects a Stdlib::Absolutepath = Variant[Stdlib::Windowspath = Pattern[/\A(([a-zA-Z]:[\\\/])|([\\\/][\\\/][^\\\/]+[\\\/][^\\\/]+)|([\\\/][\\\/]\?[\\\/][^\\\/]+)).*\z/], Stdlib::Unixpath = Pattern[/\A\/([^\n\/\0]+\/*)*\z/]] value, got String (file: /etc/puppet/code/environments/prom_module_upgrade/3rdparty/modules/pgbackrest/manifests/repository/stanza.pp, line: 77) on node backup-storage-01.torproject.org
I don't know of another way to fix this than to make this a proper string.
Closes: voxpupuli#510
kenyon
reviewed
Jan 15, 2025
| @@ -73,7 +73,7 @@ | |||
| Stdlib::Absolutepath $path = '/etc/systemd/system', | |||
| Optional[Variant[String, Sensitive[String], Deferred]] $content = undef, | |||
| Optional[String] $source = undef, | |||
| Optional[Stdlib::Absolutepath] $target = undef, | |||
| Optional[String] $target = undef, | |||
There was a problem hiding this comment.
Empty string isn't valid here, right?
Suggested change
| Optional[String] $target = undef, | |
| Optional[String[1]] $target = undef, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Absolutepath is exactly what it says: it forces the link target to be an absolute path, that is to start with a slash (
/). But I actually want to have relative symlinks.This is particularly useful when doing a @.service template where the instance refers to the template, often in the same directory.
This, for example, should be allowed:
Yet it currently crashes with:
I don't know of another way to fix this than to make this a proper string.
Closes: #510