Removing magic number

vtex-apps · Dec 14, 2018 · 270002f · 270002f
1 parent 0d7444e
commit 270002f
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/react/components/MiniCartContent.js b/react/components/MiniCartContent.js
@@ -189,14 +189,15 @@ class MiniCartContent extends Component {
     large
   ) => {
     const items = this.props.data.orderForm.items
+    const MIN_ITEMS_TO_SCROLL = 2
 
     const classes = classNames(
       `${minicart.content} overflow-x-hidden pa1`,
       {
         [`${minicart.contentSmall} bg-base`]: !large,
         'overflow-y-auto': large,
-        'overflow-y-scroll': items.length > 2 && !large,
-        'overflow-y-hidden': items.length <= 2 && !large,
+        'overflow-y-scroll': items.length > MIN_ITEMS_TO_SCROLL && !large,
+        'overflow-y-hidden': items.length <= MIN_ITEMS_TO_SCROLL && !large,
       }
     )