Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Feature: Jump to Location #6

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

j796160836
Copy link
Contributor

Add Feature

  • Jump to Location (Press Cmd + G to activate)

Bug Fix

  • Apply default location when GPS failed

@wangpy
Copy link
Owner

wangpy commented Aug 14, 2016

Question:

  1. What can the users do with dropped pins?
  2. In what situations do we need to manually update locations?

Style Suggestions:

  1. Change "JumpLocationViewController" to "JumpToLocationViewController"
  2. Change "JumpLocationDelegate" to "JumpToLocationViewControllerDelegate" or "JumpToLocationReceiver"
  3. Add a "delegate" or "receiver" property to JumpToLocationViewController to make it call the methods to receiver directly, and move the code in AppDelegate to JumpToLocationViewController as much as possible.
  4. change the name all button click handler method to "onXxxxxClicked"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants