Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: support --lib param of mf-dev command #590

Merged
merged 9 commits into from
Dec 24, 2024

Conversation

Timeless0911
Copy link
Contributor

@Timeless0911 Timeless0911 commented Dec 22, 2024

Breaking change

  • Modify mf dev command name to mf-dev to accect more params

Summary

  • Support --lib param of mf-dev command
  • Use EnvironmentConfig type in lib field
  • Use EnvironmentConfig instead of RsbuildConfig types in composing Rsbuild config in Rslib internal logic
  • Put below config to outside of environments config since they are global configuration of Rsbuild
    • mode
    • root
    • dev
    • plugins
    • server
  • Should write server config in shared Rsbuild configurations instead of object of lib array which represents environments config

Related Links

closes: #513
closes: #555

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Dec 22, 2024

Deploy Preview for rslib ready!

Name Link
🔨 Latest commit a735c83
🔍 Latest deploy log https://app.netlify.com/sites/rslib/deploys/67681e8f4b79910008e99092
😎 Deploy Preview https://deploy-preview-590--rslib.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Timeless0911 Timeless0911 marked this pull request as ready for review December 22, 2024 14:17
Copy link

netlify bot commented Dec 22, 2024

Deploy Preview for rslib ready!

Name Link
🔨 Latest commit 21fa485
🔍 Latest deploy log https://app.netlify.com/sites/rslib/deploys/676952de50b55e00081e7cbb
😎 Deploy Preview https://deploy-preview-590--rslib.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Timeless0911 Timeless0911 force-pushed the feature/support-mf-dev-lib branch from f3cf56b to 83bcfd5 Compare December 22, 2024 14:29
@Timeless0911 Timeless0911 marked this pull request as draft December 22, 2024 14:52
@Timeless0911 Timeless0911 marked this pull request as ready for review December 23, 2024 09:41
@Timeless0911 Timeless0911 force-pushed the feature/support-mf-dev-lib branch 2 times, most recently from 8e72dba to 21fa485 Compare December 23, 2024 12:09
Copy link

codspeed-hq bot commented Dec 23, 2024

CodSpeed Performance Report

Merging #590 will not alter performance

Comparing feature/support-mf-dev-lib (3ede44d) with main (4416f02)

Summary

✅ 5 untouched benchmarks

@fi3ework fi3ework changed the title feat: support --lib param of mf-dev command feat!: support --lib param of mf-dev command Dec 24, 2024
@fi3ework fi3ework force-pushed the feature/support-mf-dev-lib branch from 3ede44d to 7e8bc03 Compare December 24, 2024 06:49
@fi3ework fi3ework enabled auto-merge (squash) December 24, 2024 06:50
@fi3ework fi3ework merged commit bf897f4 into main Dec 24, 2024
13 of 17 checks passed
@fi3ework fi3ework deleted the feature/support-mf-dev-lib branch December 24, 2024 06:52
@Timeless0911 Timeless0911 mentioned this pull request Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants