Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure token address is a string #753

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Conversation

artursapek
Copy link
Collaborator

@artursapek artursapek commented Dec 11, 2024

This function has a bug: it accepts type AnySolanaAddress[] where AnySolanaAddress is either a Solana NativeAddress or a PublicKeyInitData from web3.js which can be a string... but then it assumes it's working with a string in this equality check because the RPC response account.data.parsed?.info?.mint is a string.

This change ensures that we are indeed comparing a string to a string.

@artursapek artursapek merged commit 4b43423 into main Dec 11, 2024
1 check failed
@artursapek artursapek deleted the fix-spl-balance-fetching branch December 11, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants