properly closing response bodies when done with them

yellowbluesky · Jan 28, 2024 · a5f48c0 · a5f48c0
1 parent 68db12d
commit a5f48c0
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/app/src/main/java/com/antony/muzei/pixiv/provider/PixivArtWorker.kt b/app/src/main/java/com/antony/muzei/pixiv/provider/PixivArtWorker.kt
@@ -234,6 +234,7 @@ class PixivArtWorker(context: Context, workerParams: WorkerParameters) :
 
         // The other method using BufferedSink doesn't work all we have is a URI to sink into
         val fis = responseBody!!.byteStream()
+        responseBody.close()
         val fosExternal: OutputStream? = contentResolver.openOutputStream(imageUri)
         val buffer = ByteArray(1024 * 1024 * 10)
         var lengthInternal: Int
@@ -453,6 +454,8 @@ class PixivArtWorker(context: Context, workerParams: WorkerParameters) :
                 if (it.isSuccessful) {
                     Log.i(LOG_TAG, "Getting remote file extensions completed")
                     return it.body
+                } else {
+                    it.close()
                 }
             }
         }