frontendscanner: correct API parameter name

Use the correct case, `fileName` instead of `filename`, otherwise it will fail with a 400 when loading the injected script. Signed-off-by: drighty <107853737+drighty@users.noreply.github.com>
zaproxy · Oct 19, 2023 · d20e78e · d20e78e
1 parent 4ef8f17
commit d20e78e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/...src/main/java/org/zaproxy/zap/extension/frontendscanner/FrontEndScannerProxyListener.java b/...src/main/java/org/zaproxy/zap/extension/frontendscanner/FrontEndScannerProxyListener.java
@@ -137,7 +137,7 @@ private static String getScriptToInject(String frontEndApiUrl, int historyRefere
                         .append("<script src='")
                         .append(frontEndApiUrl)
                         .append("?action=getFile")
-                        .append("&filename=front-end-scanner.js")
+                        .append("&fileName=front-end-scanner.js")
                         .append("&historyReferenceId=")
                         .append(historyReferenceId)
                         .append("'></script>");

diff --git a/.../java/org/zaproxy/zap/extension/frontendscanner/FrontEndScannerProxyListenerUnitTest.java b/.../java/org/zaproxy/zap/extension/frontendscanner/FrontEndScannerProxyListenerUnitTest.java
@@ -98,7 +98,7 @@ void testInjectTheFrontEndTrackerBeforeOtherScriptsInHeadTag() {
         String expectedHtmlFormat =
                 "<!doctype html><html lang='en'><head><script src='https:\\/\\/"
                         + HOSTNAME
-                        + "\\/zapCallBackUrl\\/-?[0-9]+\\?action=getFile&filename=front-end-scanner.js&historyReferenceId=42'><\\/script><script><\\/script><\\/head><body><\\/body></html>";
+                        + "\\/zapCallBackUrl\\/-?[0-9]+\\?action=getFile&fileName=front-end-scanner.js&historyReferenceId=42'><\\/script><script><\\/script><\\/head><body><\\/body></html>";
         String result = msg.getResponseBody().toString();
 
         assertTrue(result.matches(expectedHtmlFormat));
@@ -118,7 +118,7 @@ void testInjectAfterMetaTagInHeadTag() {
         String expectedHtmlFormat =
                 "<!doctype html><html lang='en'><head><meta><script src='https:\\/\\/"
                         + HOSTNAME
-                        + "\\/zapCallBackUrl\\/-?[0-9]+\\?action=getFile&filename=front-end-scanner.js&historyReferenceId=42'><\\/script><\\/head><body><\\/body></html>";
+                        + "\\/zapCallBackUrl\\/-?[0-9]+\\?action=getFile&fileName=front-end-scanner.js&historyReferenceId=42'><\\/script><\\/head><body><\\/body></html>";
         String result = msg.getResponseBody().toString();
 
         assertTrue(result.matches(expectedHtmlFormat));
@@ -139,7 +139,7 @@ void testInjectAfterAllMetaTagsInHeadTag() {
         String expectedHtmlFormat =
                 "<!doctype html><html lang='en'><head><meta><meta><script src='https:\\/\\/"
                         + HOSTNAME
-                        + "\\/zapCallBackUrl\\/-?[0-9]+\\?action=getFile&filename=front-end-scanner.js&historyReferenceId=42'><\\/script><\\/head><body><\\/body></html>";
+                        + "\\/zapCallBackUrl\\/-?[0-9]+\\?action=getFile&fileName=front-end-scanner.js&historyReferenceId=42'><\\/script><\\/head><body><\\/body></html>";
         String result = msg.getResponseBody().toString();
 
         assertTrue(result.matches(expectedHtmlFormat));
@@ -159,7 +159,7 @@ void testInjectionShouldBeSuccessfulWithoutHead() {
         String expectedHtmlFormat =
                 "<!doctype html><html lang='en'><head><script src='https:\\/\\/"
                         + HOSTNAME
-                        + "\\/zapCallBackUrl\\/-?[0-9]+\\?action=getFile&filename=front-end-scanner.js&historyReferenceId=42'><\\/script><\\/head><body><\\/body></head></html>";
+                        + "\\/zapCallBackUrl\\/-?[0-9]+\\?action=getFile&fileName=front-end-scanner.js&historyReferenceId=42'><\\/script><\\/head><body><\\/body></head></html>";
         String result = msg.getResponseBody().toString();
 
         assertTrue(result.matches(expectedHtmlFormat));
@@ -179,7 +179,7 @@ void testInjectionShouldBeSuccessfulWithEmptyHead() {
         String expectedHtmlFormat =
                 "<!doctype html><html lang='en'><head><script src='https:\\/\\/"
                         + HOSTNAME
-                        + "\\/zapCallBackUrl\\/-?[0-9]+\\?action=getFile&filename=front-end-scanner.js&historyReferenceId=42'><\\/script><\\/head><body><\\/body></html>";
+                        + "\\/zapCallBackUrl\\/-?[0-9]+\\?action=getFile&fileName=front-end-scanner.js&historyReferenceId=42'><\\/script><\\/head><body><\\/body></html>";
         String result = msg.getResponseBody().toString();
 
         assertTrue(result.matches(expectedHtmlFormat));
@@ -199,7 +199,7 @@ void testInjectionShouldBeSuccessfulWithoutHtmlTag() {
         String expectedHtmlFormat =
                 "<head><script src='https:\\/\\/"
                         + HOSTNAME
-                        + "\\/zapCallBackUrl\\/-?[0-9]+\\?action=getFile&filename=front-end-scanner.js&historyReferenceId=42'><\\/script><\\/head><body><\\/body>";
+                        + "\\/zapCallBackUrl\\/-?[0-9]+\\?action=getFile&fileName=front-end-scanner.js&historyReferenceId=42'><\\/script><\\/head><body><\\/body>";
         String result = msg.getResponseBody().toString();
 
         assertTrue(result.matches(expectedHtmlFormat));
@@ -219,7 +219,7 @@ void testInjectionShouldBeSuccessfulWithoutHtmlNorHeadTag() {
         String expectedHtmlFormat =
                 "<head><script src='https:\\/\\/"
                         + HOSTNAME
-                        + "\\/zapCallBackUrl\\/-?[0-9]+\\?action=getFile&filename=front-end-scanner.js&historyReferenceId=42'><\\/script><\\/head><body><\\/body>";
+                        + "\\/zapCallBackUrl\\/-?[0-9]+\\?action=getFile&fileName=front-end-scanner.js&historyReferenceId=42'><\\/script><\\/head><body><\\/body>";
         String result = msg.getResponseBody().toString();
 
         assertTrue(result.matches(expectedHtmlFormat));