Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

network: add support for br content encoding #5100

Merged
merged 1 commit into from
Nov 17, 2023
Merged

network: add support for br content encoding #5100

merged 1 commit into from
Nov 17, 2023

Conversation

thc202
Copy link
Member

@thc202 thc202 commented Nov 16, 2023

Support encoding/decoding on Linux x64, macOS, and Windows x64.

Part of zaproxy/zaproxy#2198.

ricekot
ricekot reviewed Nov 17, 2023
View reviewed changes
Copy link
Member

@ricekot ricekot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected :), tested with the following request:

GET https://www.zaproxy.org/ HTTP/2
accept-encoding: br
content-length: 0

Have a few other minor comments.

addOns/network/src/main/java/org/zaproxy/addon/network/internal/ContentEncodingsHandler.java Show resolved Hide resolved
addOns/network/src/main/javahelp/help/contents/options/localservers.html Outdated Show resolved Hide resolved
addOns/network/src/main/java/org/zaproxy/addon/network/internal/HttpEncodingBrotli.java Show resolved Hide resolved
@thc202
network: add support for br content encoding
5a896fc 
Support encoding/decoding on Linux x64, macOS, and Windows x64.

Part of zaproxy/zaproxy#2198.

Signed-off-by: thc202 <thc202@gmail.com>
@thc202 thc202 force-pushed the network/add-br-support branch from 2cabee6 to 5a896fc Compare November 17, 2023 07:53
ricekot
ricekot approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@ricekot ricekot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

psiinon
psiinon approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@psiinon psiinon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my macBook M2!

@psiinon psiinon merged commit 542067c into zaproxy:main Nov 17, 2023
10 checks passed
@thc202 thc202 mentioned this pull request Nov 17, 2023
Closed
@thc202 thc202 deleted the network/add-br-support branch November 17, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricekot ricekot ricekot approved these changes

@kingthorin kingthorin kingthorin approved these changes

@psiinon psiinon psiinon approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thc202 @psiinon @kingthorin @ricekot