pscanrules: Big Redirect rule - Also alert on multiple HREFs in body #5153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
kingthorin
force-pushed
the
big-redir-links
branch
from
9fd62d6 to
2ab42c7
Compare
thc202
reviewed
Dec 10, 2023
addOns/pscanrules/src/main/java/org/zaproxy/zap/extension/pscanrules/BigRedirectsScanRule.java
Outdated
Show resolved
Hide resolved
kingthorin
force-pushed
the
big-redir-links
branch
from
2ab42c7 to
1375f98
Compare
|
Tweaked help cross links. |
thc202
reviewed
Dec 11, 2023
addOns/pscanrules/src/main/java/org/zaproxy/zap/extension/pscanrules/BigRedirectsScanRule.java
Outdated
Show resolved
Hide resolved
addOns/pscanrules/src/main/java/org/zaproxy/zap/extension/pscanrules/BigRedirectsScanRule.java
Outdated
Show resolved
Hide resolved
addOns/pscanrules/src/main/java/org/zaproxy/zap/extension/pscanrules/BigRedirectsScanRule.java
Outdated
Show resolved
Hide resolved
addOns/pscanrules/src/main/java/org/zaproxy/zap/extension/pscanrules/BigRedirectsScanRule.java
Outdated
Show resolved
Hide resolved
addOns/pscanrules/src/main/java/org/zaproxy/zap/extension/pscanrules/BigRedirectsScanRule.java
Outdated
Show resolved
Hide resolved
...c/main/javahelp/org/zaproxy/zap/extension/pscanrules/resources/help/contents/pscanrules.html
Show resolved
Hide resolved
...nrules/src/main/resources/org/zaproxy/zap/extension/pscanrules/resources/Messages.properties
Outdated
Show resolved
Hide resolved
...nrules/src/main/resources/org/zaproxy/zap/extension/pscanrules/resources/Messages.properties
Outdated
Show resolved
Hide resolved
...anrules/src/test/java/org/zaproxy/zap/extension/pscanrules/BigRedirectsScanRuleUnitTest.java
Outdated
Show resolved
Hide resolved
kingthorin
force-pushed
the
big-redir-links
branch
from
1375f98 to
2e6ae71
Compare
|
Review addressed |
- BigRedirectScanRule > Add further functionality to check if the response contains multiple HREFs, example alerts, and Alert Refs. - BigRedirectScanRuleUnitTest > Add tests for new behavior, example alerts, and alert refs. - CHANGELOG > Add change notes. - Messages.properties > Add supporting resources. - pscanrules.html > Update help entry. Signed-off-by: kingthorin <kingthorin@users.noreply.github.com>
kingthorin
force-pushed
the
big-redir-links
branch
from
2e6ae71 to
598594e
Compare
|
"Should" be good now. |
thc202
approved these changes
Dec 12, 2023
|
Thank you! |
psiinon
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Hat tip to @xnl-h4ck3r for the idea: https://twitter.com/xnl_h4ck3r/status/1724808036706091496
Related Issues
Checklist
./gradlew spotlessApplyfor code formatting