Fix split view splitters being offset by sidebar #4088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
| + if (this._sidebarResizeObserver) { | ||
| + this._sidebarResizeObserver.disconnect(); | ||
| + } | ||
| + this._sidebarResizeObserver = new ResizeObserver(async () => { |
There was a problem hiding this comment.
I dont think we should add an observer, I believe there are better ways...
There was a problem hiding this comment.
I found an easier solution by simply moving the splitview-overlay and wrapper into the tabbrowser so the inset % will be correct based on the tabpanels width.
I think it makes more sense for splitview overlay to be nested within the tabpanel so its always the correct size vs. doing extra calculations. I also removed the xhtml file since it seemed to be the occurrence
dosubot
bot
added
size:S
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2761
Splitters were calculated using the entire split view overlay which results in an incorrect inset % when a sidebar is present.
Recording.2024-12-30.203029.mp4
A padding-left or padding-right (depending on sidebar position) equal to the sidebar width is added to the overlay for the inset % to be correct. This padding is recalculated under the following actions
splitview.mp4