fix: fixes image sizing on 4k displays for home page #392
+5
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks arguably worse, no? |
|
@mr-cheff which part? is it the smaller images? I can adjust them. it's mainly the bottom three images that are clipping and have their size too big. |
|
The features image is insanely small |
|
@mr-cheff I've made the "Features" image bigger. It's still slightly smaller than what it originally was, but I feel like the original is too big considering the small content beside it. Here's the final looks of new changes:
i've also removed the extra spacing that i added in my previous commit to the bottom three images (since original site didn't have it either) |
|
Happy to change anything if you need |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
problem: we don't have proper handling of elements for 4k displays. this causes warping on 2 of the home images.
fix: added a new breakpoint for 4k displays to tailwind config, and applied fixes to the images using that breakpoint. below are comparisons (using chrome because I hate firefox responsiveness editor).
old:
new:
