Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(oidc): return defined error when discovery failed #653

Merged
merged 6 commits into from
Sep 20, 2024

Conversation

ay4toh5i
Copy link
Contributor

This PR adds a specific error to handle discovery failures.
It allows proper error handling when the issuer URL is invalid or the configuration is missing.
Thank you.

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.09%. Comparing base (0992c5f) to head (9af7d5e).
Report is 93 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #653      +/-   ##
==========================================
+ Coverage   60.06%   62.09%   +2.03%     
==========================================
  Files          80       81       +1     
  Lines        6998     6218     -780     
==========================================
- Hits         4203     3861     -342     
+ Misses       2498     2047     -451     
- Partials      297      310      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@muhlemmer muhlemmer self-requested a review September 17, 2024 10:15
pkg/client/client.go Outdated Show resolved Hide resolved
pkg/client/client_test.go Outdated Show resolved Hide resolved
pkg/oidc/verifier.go Show resolved Hide resolved
ay4toh5i and others added 4 commits September 17, 2024 23:10
Co-authored-by: Tim Möhlmann <muhlemmer@gmail.com>
Co-authored-by: Tim Möhlmann <muhlemmer@gmail.com>
Co-authored-by: Tim Möhlmann <muhlemmer@gmail.com>
@ay4toh5i ay4toh5i force-pushed the feature/defined-error-in-discovery branch from 5447405 to 81c89c3 Compare September 17, 2024 14:43
@ay4toh5i ay4toh5i requested a review from muhlemmer September 17, 2024 14:52
@ay4toh5i
Copy link
Contributor Author

@muhlemmer
Thanks for taking the time to review my PR and for the feedback!
I’ve addressed the points you mentioned. Could you take another look when you get a chance?

Co-authored-by: Tim Möhlmann <muhlemmer@gmail.com>
@muhlemmer muhlemmer merged commit 3b64e79 into zitadel:main Sep 20, 2024
7 checks passed
Copy link

🎉 This PR is included in version 3.30.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants