bug fix

zktx-io · Jan 13, 2025 · d846d8a · d846d8a
1 parent f1b8007
commit d846d8a
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 19 deletions.
diff --git a/packages/ptb-builder/src/ptbFlow/components/CmdParamsVector.tsx b/packages/ptb-builder/src/ptbFlow/components/CmdParamsVector.tsx
@@ -1,7 +1,5 @@
 import React, { useEffect, useState } from 'react';
 
-import { useUpdateNodeInternals } from '@xyflow/react';
-
 import { useStateContext } from '../../provider';
 import { PtbHandle, PtbHandleArray, PtbHandleVector } from '../nodes/handles';
 import { ButtonStyles, InputStyle } from '../nodes/styles';
@@ -17,7 +15,6 @@ const YStart = 74;
 const YGap = 24;
 
 interface CmdParamsVectorProps {
-  id: string;
   data: PTBNodeData;
   resetEdge: (handle: 'source' | 'target') => void;
   updateState: (type: TYPE_PARAMS, omit: boolean, splitInputs?: number) => void;
@@ -37,13 +34,11 @@ const PARAMS: TYPE_PARAMS[] = [
 ];
 
 export const CmdParamsVector = ({
-  id,
   data,
   resetEdge,
   updateState,
 }: CmdParamsVectorProps) => {
   const { canEdit } = useStateContext();
-  const updateNodeInternals = useUpdateNodeInternals();
 
   const [isSplitInputs, setIsSplitInputs] = useState<boolean>(
     !!data.splitInputs || false,
@@ -84,7 +79,6 @@ export const CmdParamsVector = ({
       resetEdge('target');
       setInputs((old) => old.slice(0, -1));
       updateState(type, omit, inputs.length - 1);
-      updateNodeInternals(id);
     }
   };
 
@@ -93,15 +87,6 @@ export const CmdParamsVector = ({
     // eslint-disable-next-line react-hooks/exhaustive-deps
   }, []);
 
-  const handleResetEdge = (handle: 'source' | 'target') => {
-    resetEdge(handle);
-    updateNodeInternals(id);
-  };
-
-  useEffect(() => {
-    updateNodeInternals(id);
-  }, [id, updateNodeInternals]);
-
   return (
     <>
       <div className="flex items-center gap-2">
@@ -146,7 +131,7 @@ export const CmdParamsVector = ({
               onChange={(e) => {
                 setIsSplitInputs(e.target.checked);
                 handleAdd(e.target.checked);
-                handleResetEdge('target');
+                resetEdge('target');
               }}
             />
           </>

diff --git a/packages/ptb-builder/src/ptbFlow/nodes/commands/MakeMoveVec.tsx b/packages/ptb-builder/src/ptbFlow/nodes/commands/MakeMoveVec.tsx
@@ -1,6 +1,6 @@
-import React from 'react';
+import React, { useEffect } from 'react';
 
-import { useReactFlow } from '@xyflow/react';
+import { useReactFlow, useUpdateNodeInternals } from '@xyflow/react';
 
 import { PTBNodeProp } from '..';
 import { CmdParamsVector } from '../../components';
@@ -10,6 +10,7 @@ import { TYPE_PARAMS } from '../types';
 
 export const MakeMoveVec = ({ id, data }: PTBNodeProp) => {
   const { setEdges, setNodes } = useReactFlow();
+  const updateNodeInternals = useUpdateNodeInternals();
 
   const resetEdge = (handle: 'source' | 'target') => {
     setEdges((eds) =>
@@ -22,8 +23,13 @@ export const MakeMoveVec = ({ id, data }: PTBNodeProp) => {
           ),
       ),
     );
+    updateNodeInternals(id);
   };
 
+  useEffect(() => {
+    updateNodeInternals(id);
+  }, [id, updateNodeInternals]);
+
   return (
     <div className={NodeStyles.command}>
       <p className="text-base text-center text-gray-700 dark:text-gray-400">
@@ -42,7 +48,6 @@ export const MakeMoveVec = ({ id, data }: PTBNodeProp) => {
         }}
       />
       <CmdParamsVector
-        id={id}
         data={data}
         resetEdge={resetEdge}
         updateState={(
@@ -65,6 +70,7 @@ export const MakeMoveVec = ({ id, data }: PTBNodeProp) => {
               return node;
             }),
           );
+          updateNodeInternals(id);
         }}
       />
     </div>