-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for Python 3.7. #153
Conversation
Additionally to the broken MacOS jobs the code for setting the branch protection rules seems to be wrong here. |
Looks like this is the first |
P.S.: @tseaver had a good point recently that running a bunch of tests that aren't really important are a waste of energy. We're continuing to do that in many places because we're not paying for it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running the tests on macos was added in #141 because the query plan was sometimes different there.
Note: I do not plan to work on fixing this PR. |
I will fix it. |
The fix for macOS is the same as already used for Zope itself: C-based packages must be pre-installed with pip because zc.buildout/setuptools messes it all up. This dependency pre-install might be moved from individual packages' meta configuration into the meta templates itself, if I encounter another package like that I'll handle it. |
Thank you for working on this PR. 😃 |
No description provided.