Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.7. #153

Merged
merged 8 commits into from
Jul 11, 2024

Conversation

icemac
Copy link
Member

@icemac icemac commented Jun 18, 2024

No description provided.

@icemac icemac requested a review from dataflake June 18, 2024 07:19
@icemac icemac self-assigned this Jun 18, 2024
@icemac
Copy link
Member Author

icemac commented Jun 18, 2024

Additionally to the broken MacOS jobs the code for setting the branch protection rules seems to be wrong here.

@dataflake
Copy link
Member

Looks like this is the first zope-product project that has set with-macos = true other than Zope itself. Obviously, there's a bug. But is it really necessary to run macOS tests here?

@dataflake
Copy link
Member

P.S.: @tseaver had a good point recently that running a bunch of tests that aren't really important are a waste of energy. We're continuing to do that in many places because we're not paying for it.

Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running the tests on macos was added in #141 because the query plan was sometimes different there.

.github/workflows/tests.yml Show resolved Hide resolved
@icemac
Copy link
Member Author

icemac commented Jun 19, 2024

Testing on MacOS was added in #141 because of the bug in #140. It seems to behave differently that's why we are testing it.

@icemac
Copy link
Member Author

icemac commented Jun 19, 2024

Note: I do not plan to work on fixing this PR.

@icemac icemac removed their assignment Jun 19, 2024
@dataflake
Copy link
Member

I will fix it.

@dataflake dataflake self-assigned this Jun 19, 2024
@dataflake
Copy link
Member

The fix for macOS is the same as already used for Zope itself: C-based packages must be pre-installed with pip because zc.buildout/setuptools messes it all up. This dependency pre-install might be moved from individual packages' meta configuration into the meta templates itself, if I encounter another package like that I'll handle it.

@icemac icemac merged commit 751bd3d into master Jul 11, 2024
18 checks passed
@icemac icemac deleted the config-with-zope-product-template-c412f00f branch July 11, 2024 07:15
@icemac
Copy link
Member Author

icemac commented Jul 11, 2024

Thank you for working on this PR. 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants