Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix students context menu #6440

Merged
merged 2 commits into from
Jan 30, 2023
Merged

Fix students context menu #6440

merged 2 commits into from
Jan 30, 2023

Conversation

mikeyarce
Copy link
Member

Fixes #6123

Changes proposed in this Pull Request

  • Update @wp-components to version wp-6.1

With the old component, there is a problem with the students context menu not showing properly. Updating to the latest component fixes that issue.

Testing instructions

  • Go to Sensei -> Students
  • Click the ... menu
  • Make sure it opens up

Example:
student-context-menu

Also, I wasn't sure if I needed to push package-lock.json? It wasn't in .gitignore so.... let me know!

@mikeyarce mikeyarce requested a review from a team January 29, 2023 18:49
@mikeyarce mikeyarce changed the title Update wordpress/omponents to wp-6.1 version Fix students context menu Jan 29, 2023
Copy link
Member

@merkushin merkushin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Works great!

@mikeyarce mikeyarce merged commit 3909bb5 into trunk Jan 30, 2023
@mikeyarce mikeyarce deleted the fix/students-modal-menu branch January 30, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 dots menu on Students page opens to the right, half of it not visible
2 participants