Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Обновление спецификации: Правка Группирования #96

Merged
merged 17 commits into from
Oct 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
761d14f
RevitDeclarations: Исправлена ошибка выгрузки при неактивированном Ex…
sssenya Sep 13, 2024
3e92848
RevitPylonDocumentation: Проведен рефакторинг (#84)
DivinN Sep 16, 2024
9621576
RevitServerFolders: Корректировка сообщений логов (#85)
vlastroG Sep 18, 2024
4959b23
RevitServerFolders: Исправление ошибки с поиском элементов на виде (#87)
vlastroG Sep 24, 2024
9310e7d
RevitMechanicalSpecification: Создан плагин (#86)
Redomine Oct 2, 2024
4fd92ec
Merge branch 'master' of https://github.com/Bim4Everyone/RevitPlugins
Redomine Oct 3, 2024
6b285ed
Merge branch 'master' of https://github.com/Bim4Everyone/RevitPlugins
Redomine Oct 7, 2024
75931ed
Merge branch 'master' of https://github.com/Bim4Everyone/RevitPlugins
Redomine Oct 8, 2024
4cda428
Merge branch 'master' of https://github.com/Bim4Everyone/RevitPlugins
Redomine Oct 9, 2024
56ffc99
Merge branch 'master' of https://github.com/Bim4Everyone/RevitPlugins
Redomine Oct 9, 2024
8fb8a31
Merge branch 'master' of https://github.com/Bim4Everyone/RevitPlugins
Redomine Oct 10, 2024
b1e2e66
ФОП_ВИС_Группирование некорректно заполнялся для металла фитингов, по…
Redomine Oct 10, 2024
8dbad03
Лишний пробел в именах
Redomine Oct 10, 2024
9c758f6
Merge branch 'master' of https://github.com/Bim4Everyone/RevitPlugins
Redomine Oct 10, 2024
8e8575a
Merge branch 'master' into Redomine/MechanicalSpecificationGroupingFix
Redomine Oct 10, 2024
0002a90
Проверяем коммиты
Redomine Oct 10, 2024
ad23dbb
Проверяем коммиты
Redomine Oct 10, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ public class SpecificationElement {
private Element _elementType;
private BuiltInCategory _builtInCategory;
private string _elementName;
private string _elementMark;
private FamilyInstance _manifoldInstance = null;
private SpecificationElement _manifoldSpElement;
private SpecificationElement _insulationSpHost;
Expand Down Expand Up @@ -46,6 +47,11 @@ public string ElementName {
set => _elementName = value;
}

public string ElementMark {
get => _elementMark;
set => _elementMark = value;
}

public FamilyInstance ManifoldInstance {
get => _manifoldInstance;
set => _manifoldInstance = value;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,10 @@ private string GetBaseGroup(Element element) {
/// </summary>
private string GetDetailedGroup(SpecificationElement specificationElement) {
string name = specificationElement.ElementName;
string mark = specificationElement.GetTypeOrInstanceParamStringValue(Config.OriginalParamNameMark);
string mark = !string.IsNullOrEmpty(specificationElement.ElementMark)
? specificationElement.ElementMark
: specificationElement.GetTypeOrInstanceParamStringValue(Config.OriginalParamNameMark);

string code = specificationElement.GetTypeOrInstanceParamStringValue(Config.OriginalParamNameCode);
string creator = specificationElement.GetTypeOrInstanceParamStringValue(Config.OriginalParamNameCreator);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ private string GetMark(SpecificationElement specificationElement) {

if(specificationElement.BuiltInCategory == BuiltInCategory.OST_DuctFitting) {
mark = _calculator.GetDuctFittingMark(specificationElement.Element);
specificationElement.ElementMark = mark;
}

return mark;
Expand Down
13 changes: 7 additions & 6 deletions src/RevitMechanicalSpecification/Models/RevitRepository.cs
Original file line number Diff line number Diff line change
Expand Up @@ -53,19 +53,20 @@ public RevitRepository(UIApplication uiApplication) {
_specConfiguration,
Document,
_calculator),
//Заполнение ФОП_ВИС_Группирование
new ElementParamGroupFiller(
_specConfiguration.TargetNameGroup,
null,
_specConfiguration,
Document),
//Заполнение ФОП_ВИС_Марка
new ElementParamMarkFiller(
_specConfiguration.TargetNameMark,
_specConfiguration.OriginalParamNameMark,
_specConfiguration,
_calculator,
Document),
//Заполнение ФОП_ВИС_Группирование
new ElementParamGroupFiller(
_specConfiguration.TargetNameGroup,
null,
_specConfiguration,
Document),

//Заполнение ФОП_ВИС_Код изделия
new ElementParamDefaultFiller(
_specConfiguration.TargetNameCode,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,19 +75,19 @@ public string GetDuctFittingName(Element element) {

switch(fitting.PartType) {
case PartType.Transition:
startName = "Переход между сечениями воздуховода ";
startName = "Переход между сечениями воздуховода";
break;
case PartType.Tee:
startName = "Тройник ";
startName = "Тройник";
break;
case PartType.TapAdjustable:
startName = "Врезка в воздуховод ";
startName = "Врезка в воздуховод";
break;
case PartType.Cross:
startName = "Крестовина ";
startName = "Крестовина";
break;
case PartType.Cap:
startName = "Заглушка ";
startName = "Заглушка";
break;
case PartType.Union:
return "!Не учитывать";
Expand Down
Loading